Conversation
narendasan
reviewed
Jan 30, 2026
Collaborator
narendasan
left a comment
narendasan
left a comment
There was a problem hiding this comment.
Just add a simple test to make sure the extra file is there after deserialization
narendasan
reviewed
Jan 30, 2026
Collaborator
narendasan
left a comment
narendasan
left a comment
There was a problem hiding this comment.
alternatively do you think its a good idea to just pass generic kwargs to the underlying save and load?
cehongwang
force-pushed
the
cehongw/save-extra-args
branch
from
b885722 to
e2b04a8
Compare
narendasan
reviewed
Feb 2, 2026
| ) | ||
|
|
||
|
|
||
| def function_overload_with_kwargs( |
Collaborator
There was a problem hiding this comment.
I think you can uses functools partials for this, might be a bit more stable
cehongwang
force-pushed
the
cehongw/save-extra-args
branch
from
e2b04a8 to
75e0e20
Compare
Collaborator
|
@cehongwang can you retrigger tests? |
cehongwang
force-pushed
the
cehongw/save-extra-args
branch
from
75e0e20 to
eff473f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: