Do not mandate a specific dead code policy in NoReturn conformance test#2175
Open
migeed-z wants to merge 1 commit intopython:mainfrom
Open
Do not mandate a specific dead code policy in NoReturn conformance test#2175migeed-z wants to merge 1 commit intopython:mainfrom
NoReturn conformance test#2175migeed-z wants to merge 1 commit intopython:mainfrom
Conversation
carljm
reviewed
Feb 13, 2026
migeed-z
force-pushed
the
specialtypes-never-remove-dead-code-lines
branch
from
08ec3f8 to
4be5b0f
Compare
carljm
approved these changes
Feb 13, 2026
migeed-z
force-pushed
the
specialtypes-never-remove-dead-code-lines
branch
from
4be5b0f to
064de64
Compare
carljm
approved these changes
Feb 13, 2026
JelleZijlstra
approved these changes
Feb 13, 2026
rchen152
approved these changes
Feb 13, 2026
Member
|
@erictraut does this change look OK to you? |
srittau
added
the
topic: conformance tests
meta-codesync bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Feb 14, 2026
Summary: If python/typing#2175 is merged, then we don't need the previous text. Reviewed By: grievejia Differential Revision: D93298758 fbshipit-source-id: 19fda9df9d32643def051aa70a179f446c111fa2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changed conformance test to prevent mandating a specific policy for dead code, since the spec does not require one.
The full discussion is here #2174.
Test plan:
I pinned the existing versions of all existing type checkers and followed the instructions otherwise, so we do not get unrelated changes in the PR.