Skip to content

[Fix] Only add processes which exist in process_dict#913

Merged
jan-janssen merged 4 commits intomainfrom
file_wait_fix
Feb 14, 2026
Merged

[Fix] Only add processes which exist in process_dict#913
jan-janssen merged 4 commits intomainfrom
file_wait_fix

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Feb 14, 2026

Summary by CodeRabbit

  • Refactor
    • Improved task scheduling efficiency through optimized resource field propagation.
    • Enhanced queue management for task processing.
    • Streamlined task dependency handling with refined filtering.
    • Consolidated task resource parameter extraction for consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Refactored execute_tasks_h5 function to consolidate resource dictionary management through a new _get_task_input helper. Introduced queue ID extraction via get_queue_id(file_name) and simplified file naming logic while restricting dependency resolution to existing process dict keys.

Changes

Cohort / File(s) Summary
Task Execution Refactoring
src/executorlib/task_scheduler/file/shared.py
Added _get_task_input helper to merge resource dict keys and extract cache metadata. Integrated get_queue_id for queue-based task handling. Refactored file naming logic and constrained future dependency inclusion to pre-existing process dict entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Suggested reviewers

  • liamhuber

Poem

🐰 A helper born to merge and glean,
Where cache keys rest and queues convene,
Task dependencies grow lean and true,
File names dance in queue's soft hue,
Executors hop through paths anew!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch file_wait_fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jan-janssen jan-janssen marked this pull request as draft February 14, 2026 11:18
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (eb420fd) to head (1c1e058).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
+ Coverage   93.66%   93.68%   +0.01%     
==========================================
  Files          38       38              
  Lines        1911     1917       +6     
==========================================
+ Hits         1790     1796       +6     
  Misses        121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen marked this pull request as ready for review February 14, 2026 14:06
@jan-janssen jan-janssen merged commit f3af366 into main Feb 14, 2026
35 checks passed
@jan-janssen jan-janssen deleted the file_wait_fix branch February 14, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant