[Fix] TestClusterExecutor wait for futures with dependencies

[jan-janssen]

Summary by CodeRabbit

Bug Fixes

• Improved task cleanup during shutdown to ensure pending tasks are properly flushed even when certain wait conditions are disabled, preventing unresolved task entries from remaining in the system.

[coderabbitai]

📝 Walkthrough

Walkthrough

The shutdown logic in execute_tasks_h5 now includes an additional cleanup loop that refreshes the memory dictionary when either per-task or global wait flags are disabled, ensuring pending tasks are flushed before termination rather than breaking out immediately.

Changes

Cohort / File(s)	Summary
Shutdown Cleanup Enhancement src/executorlib/task_scheduler/file/shared.py	Added conditional memory-dictionary refresh loop in execute_tasks_h5's shutdown handler to flush pending tasks when wait flags are disabled, replacing immediate termination with exhaustive cleanup.

Possibly related PRs

• execute_tasks_h5() wait for future to complete #712 — Modifies execute_tasks_h5's shutdown logic to add a loop for refreshing and emptying memory_dict before termination.
• Fix: Implement one _refresh_memory_dict() function #902 — Introduces _refresh_memory_dict helper function in the same file that this PR now calls during shutdown cleanup.
• Feature: Cancel processes of cancelled futures #903 — Updates _refresh_memory_dict's signature and cancellation behavior, directly supporting the shutdown flush mechanism added here.

Poem

🐰 A rabbit hops through shutdown's maze,
Refreshing dicts in morning's haze,
No task left pending, clean and bright—
Memory flushed before the night! ✨

---

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions 'TestClusterExecutor' and 'dependencies', but the actual change modifies memory-dictionary refresh logic in execute_tasks_h5 shutdown handling, which is more specific than what the title conveys.	Revise the title to reflect the actual change, such as: '[Fix] ensure memory-dict cleanup during execute_tasks_h5 shutdown when waiting is disabled' or similar.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch TestClusterExecutorDependencies

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}