[Bug] Wait on deletion - for consistency

[jan-janssen]

No description provided.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch wait_on_del

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jan-janssen]

======================================================================
FAIL: test_independence_from_executor (unit.task_scheduler.interactive.test_dependency.TestFuture.test_independence_from_executor) [From the main process]
Ensure that futures are able to live on after the executor gets garbage
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/executorlib/executorlib/tests/unit/task_scheduler/interactive/test_dependency.py", line 85, in test_independence_from_executor
    self.assertFalse(
    ~~~~~~~~~~~~~~~~^
        future.done(),
        ^^^^^^^^^^^^^^
        msg="The submit function is slow, it should be running still",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: True is not false : The submit function is slow, it should be running still
======================================================================
FAIL: test_independence_from_executor (unit.task_scheduler.interactive.test_dependency.TestFuture.test_independence_from_executor) [From inside a class]
Ensure that futures are able to live on after the executor gets garbage
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/executorlib/executorlib/tests/unit/task_scheduler/interactive/test_dependency.py", line 135, in test_independence_from_executor
    self.assertTrue(
    ~~~~~~~~~~~~~~~^
        foo.running,
        ^^^^^^^^^^^^
        msg="We should be able to exit the run method before the task completes",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: False is not true : We should be able to exit the run method before the task completes
----------------------------------------------------------------------