Use ValueError instead of IndexError in _degrees_to_index#2648
Use ValueError instead of IndexError in _degrees_to_index#2648aman-coder03 wants to merge 5 commits intopvlib:mainfrom
Conversation
|
@aman-coder03 the tests are failing, can you take a look? |
|
@kandersolar thanks for having a look |
|
Hi, I would like to contribute this |
|
@Pradeepbeleri hi, |
|
The remaining failures are due to deprecation tests: "the tested function is scheduled to be removed in 0.14”. |
550468f to
f13ae1a
Compare
|
@kandersolar all the tests are passing now. You can have a look now! |
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
|
@cwhanse i have implemented the changes |
Wrong PR for this comment, I think. |
|
@cwhanse i committed your suggestion (removing the pytest from line 3 as it is already present on line 9)😅 |
|
is there any confusion from my end @cwhanse 😅 |
|
No, my mistake |
|
no issues! are there any additional changes required? |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Replaces
IndexErrorwithValueErrorin_degrees_to_indexfor invalidinput values.
This aligns the exception type with Python and NumPy conventions and
improves API correctness without changing behavior.
Fixes #2647