ci: enable full rivet external resolution via rivet sync#53
Merged
Conversation
Now that the rivet sync git clone compatibility fix is merged (pulseengine/rivet#44), CI can resolve external cross-references (sigil:*, kiln:*, meld:*) by cloning them via git. Strip only the local `path:` fields before syncing — CI uses the git URLs. This replaces the previous workaround that stripped the entire externals: section and suppressed errors with continue-on-error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Python -c inline script was not properly indented within the YAML block scalar, causing a workflow parse error. Replace with a single sed command that deletes absolute-path lines from rivet.yaml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Full cross-repo validation with rivet sync works (rivet#44 confirmed) but the external repos have circular dependencies and their own validation errors (1494 errors across the graph). Revert to stripping externals and local-only validation until rivet supports --local-only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: trueworkaround from Rivet Validation jobsedstripping of entireexternals:section with targeted removal of onlypath:fieldsrivet syncstep to clone external repos (kiln, meld, sigil) via git on CIsigil:*,kiln:*,meld:*)Depends on: pulseengine/rivet#44 (merged) — fixes
git clone --configcompatibility issue that preventedrivet syncfrom working on CI runners.Test plan
git clone -b main(not--config) ✓ (fixed upstream)rivet validateresolves sigil: external refs without errorrivet coveragepasses🤖 Generated with Claude Code