Merged
Conversation
gianlucam76
force-pushed
the
helm-upgrade
branch
2 times, most recently
from
8f146f2 to
6d2a9f7
Compare
Import changes: - Removed "helm.sh/helm/v3/pkg/release" and "helm.sh/helm/v4/pkg/chart/v2/util" - Added chartbase "helm.sh/helm/v4/pkg/chart", "helm.sh/helm/v4/pkg/kube", releasecommon "helm.sh/helm/v4/pkg/release/common", releasev1 "helm.sh/helm/v4/pkg/release/v1" API changes fixed: 1. util.CoalesceValues — removed (unused placeholder) 2. *release.Release → *releasev1.Release everywhere 3. Releaser interface returns → added (*releasev1.Release) type assertions in installRelease, upgradeRelease, getCurrentRelease, recoverRelease, and two statusObject.Run() call sites 4. action.CheckDependencies — converted []*chart.Dependency to []chartbase.Dependency slice at both call sites 5. chart.File → common.File in upgradeCRDsInFile 6. chart.CRD.Data → chart.CRD.File (with the file carrying the data) 7. actionConfig.Init(...) — removed the 4th debugLog argument; removed the now-unused debugLog function 8. release.Status* → releasecommon.Status*, release.Hook* → releasev1.Hook* 9. lastDeployed.Time → lastDeployed (v4 Info.LastDeployed is already time.Time) 10. installClient.Wait/Atomic/DryRun/ClientOnly/InsecureSkipTLSverify → WaitStrategy/RollbackOnFailure/DryRunStrategy/InsecureSkipTLSVerify 11. upgradeClient.Wait/Atomic/Force/Recreate/InsecureSkipTLSverify → WaitStrategy/RollbackOnFailure/ForceReplace/[removed]/InsecureSkipTLSVerify 12. uninstallClient.Wait → WaitStrategy 13. repo.Entry.InsecureSkipTLSverify → InsecureSkipTLSVerify
gianlucam76
force-pushed
the
helm-upgrade
branch
from
6d2a9f7 to
6030b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import changes:
API changes fixed: