Open
Conversation
✅ Deploy Preview for processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
praveen-rikhari
force-pushed
the
praveen/fix-404-page-with-home-link
branch
from
2501969 to
f5e475a
Compare
Collaborator
|
@Stefterv Since you were recently looking at the 404 page maybe you'll have some thoughts about this one. |
Stefterv
requested changes
Jul 12, 2024
Contributor
Stefterv
left a comment
Stefterv
left a comment
There was a problem hiding this comment.
The code looks good apart from the unnecessarily added package
The language/content probably needs some work
Contributor
There was a problem hiding this comment.
Needs a Spanish translation
| "inUse": "In use", | ||
| "notFound": "NOT FOUND", | ||
| "notFoundText": "You just hit a route that doesn't exist... the sadness.", | ||
| "backToHome": "back to home", |
Collaborator
|
@praveen-rikhari If you're still interested in this PR, could you take a look at the comments above? Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now you can see back to home page link on the 404 page