fix: handle unknown finish reasons gracefully#996
Open
cainydev wants to merge 1 commit intoprism-php:mainfrom
Open
fix: handle unknown finish reasons gracefully#996cainydev wants to merge 1 commit intoprism-php:mainfrom
cainydev wants to merge 1 commit intoprism-php:mainfrom
Conversation
cainydev
force-pushed
the
fix/handle-unknown-finish-reasons
branch
from
090d873 to
24c4faf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrismExceptionon unrecognized finish reasons (mapped toFinishReason::Unknown/OtherbyFinishReasonMap)handleStop()across all 14 affected handlers in 10 providers, returning content instead of crashingFinishReasonenum value in the response for caller inspectionTest plan