fix: sanitize control characters in ToolCall::arguments() before json_decode#937
Open
ruttydm wants to merge 2 commits intoprism-php:mainfrom
Open
fix: sanitize control characters in ToolCall::arguments() before json_decode#937ruttydm wants to merge 2 commits intoprism-php:mainfrom
ruttydm wants to merge 2 commits intoprism-php:mainfrom
Conversation
sixlive
approved these changes
Mar 3, 2026
sixlive
requested changes
Mar 3, 2026
Contributor
sixlive
left a comment
sixlive
left a comment
There was a problem hiding this comment.
Can you address CI errors please
…_decode Some providers (e.g. DeepSeek) may include raw control characters (0x00-0x1F, 0x7F) in streamed tool call argument JSON. These bytes are invalid per RFC 8259 and cause json_decode to throw a JsonException with "Control character error, possibly incorrectly encoded". Strip them before decoding. This mirrors the defensive approach already used in the OpenRouter streaming handler. Fixes prism-php#936
preg_replace() returns string|null, but json_decode() expects string. Add explicit (string) cast to satisfy both PHPStan and Rector's NullToStrictStringFuncCallArgRector rule. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ruttydm
force-pushed
the
fix/sanitize-toolcall-control-characters
branch
from
d8ed209 to
7e4d3a8
Compare
Author
|
Rebased on latest main (up to #970). CI doesn't seem to trigger for fork PRs — could a maintainer approve the workflow run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json_decodeinToolCall::arguments()JsonException: Control character error, possibly incorrectly encodedContext
Some providers (notably DeepSeek) occasionally include raw control characters in streamed tool call argument JSON. The OpenRouter handler already has defensive handling for malformed arguments — this adds similar protection at the
ToolCalllevel so all providers benefit.Fixes #936