fix(Gemini): Add Usage to StepFinishEvent#1000
Open
Plytas wants to merge 2 commits intoprism-php:mainfrom
Open
fix(Gemini): Add Usage to StepFinishEvent#1000Plytas wants to merge 2 commits intoprism-php:mainfrom
Usage to StepFinishEvent#1000Plytas wants to merge 2 commits intoprism-php:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
->withTools()->asStream()in Gemini, we're missing token usage on the intermediate LLM call:There is a code block in Gemini
Streamhandler that supposedly updates usage to include previous usage:prism/src/Providers/Gemini/Handlers/Stream.php
Lines 359 to 367 in 5d6cc65
However, this is effectively dead code as
StreamEndEventis fired before this and there's no way to retrieve this updated usage. There are no tests that hit this block.Proposed solution
I propose to expose
UsageviaStepFinishEvent. This PR only adds it to Gemini provider (as that's what I have access to), but I'd be able to add it to all instances ofStepFinishEventif needed.