Process tails when creating ManiaDifficultyHitObjects, and add additional traversal options#36556
Open
Natelytle wants to merge 6 commits intoppy:pp-devfrom
Open
Process tails when creating ManiaDifficultyHitObjects, and add additional traversal options#36556Natelytle wants to merge 6 commits intoppy:pp-devfrom
Natelytle wants to merge 6 commits intoppy:pp-devfrom
Conversation
… of traversal between columns (Shoutout my hb james tsunyoku)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 of a multi-part series in trying to get live difficulty calculation structure to support the sunny rework as it stands. Tails aren't really processed in live, so we just skip them wherever applicable, however they are important to consider going forward as the notes surrounding a tail are more important for tail-specific difficulty than the notes surrounding the head.
There are some small differences in SR compared to pp-dev from the maps I've checked, but I don't really think it matters and I'm not really willing to find the culprit unless the Smoogisheet shows the diffs greater than 0.01 stars.