Replace pagination_link_parser with ponylang/web_link#67
Merged
SeanTAllen merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
The internal PEG-based pagination_link_parser subpackage depended on ponylang/peg (which transitively pulls in kiuatan). The ponylang/web_link library implements RFC 8288 Link header parsing with zero dependencies, so switching to it simplifies the dependency tree and moves Link header parsing maintenance out of this library. The new _ExtractPaginationLinks private primitive wraps web_link's ParseLinkHeader, extracting only the prev/next URLs that pagination needs. Both paginated_list.pony and search.pony now use it instead of the old ExtractPaginationLinks + PaginationLinks match pattern. Also fixes stale CLAUDE.md entries that claimed search pagination was not implemented (it has been implemented for some time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the internal PEG-based
pagination_link_parsersubpackage (whichdepended on
ponylang/pegand transitivelykiuatan) with theponylang/web_linklibrary (v0.1.0) for RFC 8288 Link header parsing.This simplifies the dependency tree and moves Link header parsing
maintenance out of this library. A new private
_ExtractPaginationLinksprimitive wraps
web_link'sParseLinkHeader, extracting only theprev/next URLs that pagination needs.
No public API changes. Also fixes stale CLAUDE.md entries that claimed
search pagination was not implemented.