Replace simple_uri_template with ponylang/uri#66
Merged
SeanTAllen merged 3 commits intomainfrom Feb 19, 2026
Merged
Conversation
The simple_uri_template subpackage was a minimal PEG-based URI template expander that only handled RFC 6570 path segment expansion, with known limitations around encoding safety and incomplete RFC coverage. The ponylang/uri library provides a complete RFC 6570 implementation with proper per-variable percent encoding and zero external dependencies. Also fixes conflicting FFI declarations for @EXIT, @fprintf, and @pony_os_stderr between pagination_link_parser/unreachable.pony and uri/template/_unreachable.pony by updating our declarations to use the correct C types (I32 for exit status, Pointer[None] for FILE* streams).
SeanTAllen
added
the
changelog - changed
ponylang-main
added
the
discuss during sync
Internal-only change; no user-facing impact.
SeanTAllen
removed
the
changelog - changed
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the internal
simple_uri_templatesubpackage with theponylang/urilibrary (v0.1.0), which provides a complete RFC 6570 implementation with proper per-variable percent encoding.The old subpackage only handled path segment expansion (
{/var}) and had known limitations around encoding safety for special characters. All 19 call sites across 8 source files have been migrated to the newURITemplateParse/URITemplate/URITemplateVariablesAPI.Also fixes conflicting FFI declarations between
pagination_link_parser/unreachable.ponyanduri/template/_unreachable.ponyby updating our@exitparameter type fromU8toI32and stream pointer types fromPointer[U8]toPointer[None]to match the correct C types.