Merged
Conversation
ponylang-main
added
the
discuss during sync
SeanTAllen
added a commit
that referenced
this pull request
Feb 8, 2026
Replace the boolean `is_pull_request` field on `Issue` with a richer `pull_request: (IssuePullRequest | None)` field that captures the actual pull_request sub-object from GitHub's issues API (url, html_url, diff_url, patch_url, merged_at). This lets callers both distinguish PRs from true issues and access PR-specific URLs and merge status, rather than just knowing whether the pull_request key was present.
SeanTAllen
force-pushed
the
issue-pull-request-model
branch
from
c73d618 to
b40a87e
Compare
SeanTAllen
changed the title
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IssuePullRequestclass that captures thepull_requestsub-object from GitHub's issues API (url, html_url, diff_url, patch_url, merged_at)is_pull_request: BoolonIssuewithpull_request: (IssuePullRequest | None)— callers can both distinguish PRs from true issues and access PR-specific URLs/merge statusissue.is_pull_requestmust switch to matching onissue.pull_requestMotivated by Discussion #45.