Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
214bf71 to
7f0c421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
cc @juliusmarminge
This adds a simple mock update server to our setup. There are several ways to use it, docs can be added if desired.
Here are the basics:
bun run start:mock-update-serverstarts the mock update server. By default, it serves onlocalhost:3000and out of./release-mockat the project root. Both are configurable.build-desktop-artifact.tshas two more options: (a) wether or not to build with mock updates, and (b) if so, which port to use. These options control two things: (c) wether or not to output to./release-mockover./release(the default) and (d) the manifest URL built into the built Electron app.When used normally, this functionality should work fine. However, users should be aware of the manifest URL's they cause to be built into the app and/or use runtime options to ensure they spin up the mock update server on the right port.
Why
This will help us when testing the update mechanisms.
UI Changes
N/A
Checklist
I included before/after screenshots for any UI changesI included a video for animation/interaction changesNote
Add mock update server for local desktop auto-update testing
release-mock/atlocalhost:3000(configurable viaT3CODE_DESKTOP_MOCK_UPDATE_SERVER_PORT).T3CODE_DESKTOP_MOCK_UPDATESis set,configureAutoUpdaterin src/main.ts points electron-updater at the local server instead of GitHub.--mock-updatesand--mock-update-server-portflags; mock builds output torelease-mock/and publish config targets the local server.start:mock-update-servernpm script to launch the server.Macroscope summarized 7f0c421.