Open
Conversation
…admin#592) Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
williamdes
reviewed
Nov 25, 2025
Member
williamdes
left a comment
There was a problem hiding this comment.
Thank you for the PR, I am not too sure about using the in array check
Would DeSC still trigger this ?
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Author
|
Thank you for the review! Regarding the question about whether The parser normalizes keywords during lexing. So the condition is case-insensitive and mixed-case inputs won’t cause issues. To be safe, I also added additional tests covering:
All tests pass with the current implementation. |
williamdes
reviewed
Jan 2, 2026
williamdes
approved these changes
Jan 2, 2026
williamdes
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect parsing of
DESCinside index definitions inALTER TABLEstatements.Example:
This change updates AlterOperation::parse() so that ASC and DESC
are not interpreted as new statements within index definitions.
Fixes #592.