test: improve the tests for in_array

[jorgsowa]

Added more detailed descriptions to test iterations so it’s clear what the input is for each iteration. Additionally, I added a new test cases for an arrays containing references and enums.

[Girgias]

I'd rather split this test into multiple ones because trying to verify that 200 iterations of a foreach is corret is just unreasonable.

[jorgsowa]

Is splitting reference-value data into a separate test appropriate?

I added descriptions to each iteration to make the test results easier to review.
Additionally, I added an enum/object test cases, as it was missing before. I can

[Girgias]

Why not have a dictionary where the key describes the value? So you don't need the "get_type" thing...

[Girgias]

Suggested change

	//strict option OFF
	var_dump(in_array($compare,$array));
	//strict option ON
	var_dump(in_array($compare,$array,TRUE));
	//strict option OFF
	var_dump(in_array($compare,$array,FALSE));
	echo "in_array() strict=true\n";
	var_dump(in_array($compare, $array, true));
	echo "in_array() strict=false\n";
	var_dump(in_array($compare, $array, false));

[Girgias]

The current name seems to imply this is the array we are comparing against, not the one that contains the test value.

Suggested change

	$array_compare = array (
	$values = array (

[Girgias]

This test is already to long. Yes I know this is a test that has existed for a long time. But the guidelines that have existed forever now is for them to be small see https://php.github.io/php-src/miscellaneous/writing-tests.html#how-big-is-a-test-case

So I'd rather really split this massive test into smaller ones and even move them into a in_array sub folder so one can just run these tests.

[jorgsowa]

Thanks for the review. I understand you now.

All feedback has been addressed: the large test was split into 9 files inside in_array/ subfolder with a shared .inc for the descriptive-key dictionary (renamed to $values), and enum test cases were added as well.