Fix GH-157: Note elements generate semantic HTML using div instead of blockquote#244
Open
lacatoire wants to merge 1 commit intophp:masterfrom
Open
Fix GH-157: Note elements generate semantic HTML using div instead of blockquote#244lacatoire wants to merge 1 commit intophp:masterfrom
lacatoire wants to merge 1 commit intophp:masterfrom
Conversation
… of blockquote - Replace <blockquote><p> with <div> in format_note(), aligning with format_admonition() used by other admonitions (caution, warning, tip) - Change note title from <strong> to <h5 class="title"> - Remove 'note' => 'span' override for simpara, allowing <p> rendering - Remove 'note' => 'span' override for info, using default format_div - Add test for note rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<blockquote><p>with<div>informat_note(), aligning withformat_admonition()used by other admonitions (<caution>,<warning>,<tip>,<important>)<strong>to<h5 class="title">'note' => 'span'override forsimpara, allowing proper<p>rendering inside notes'note' => 'span'override forinfo, using defaultformat_div<sidebar>(which reusesformat_note) benefits automaticallyBefore:
After:
Test plan
tests/package/generic/note_rendering_001.phptcovering note with and without titleFixes #157