Fix GH-181: Empty title swallows sibling content#243
Open
lacatoire wants to merge 1 commit intophp:masterfrom
Open
Fix GH-181: Empty title swallows sibling content#243lacatoire wants to merge 1 commit intophp:masterfrom
lacatoire wants to merge 1 commit intophp:masterfrom
Conversation
When a self-closing <title/> element appeared in DocBook XML, transformFromMap() generated invalid HTML like <h3 class="title"/> which browsers parse as an unclosed <h3>, swallowing all sibling content. Emit a proper open+close pair (<h3 class="title"></h3>) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<title/>element appeared in DocBook XML,transformFromMap()generated invalid HTML like<h3 class="title"/>. HTML5 parsers treat this as an unclosed<h3>, swallowing all sibling content.transformFromMap()to emit a proper open+close pair (<h3 class="title"></h3>) for empty elements, fixing all map-based elements in one place.<title/>renders correctly with sibling content placed outside the heading.Test plan
tests/package/generic/empty_title_001.phptpasses<title/>Fixes #181