Remove duplicate Methods header in exception skeleton#276
Open
lacatoire wants to merge 1 commit intophp:masterfrom
Open
Remove duplicate Methods header in exception skeleton#276lacatoire wants to merge 1 commit intophp:masterfrom
lacatoire wants to merge 1 commit intophp:masterfrom
Conversation
The classsynopsisinfo Methods header appeared twice in exceptionname.xml, unlike classname.xml which has it once.
lacatoire
force-pushed
the
fix-skeleton-duplicate-methods
branch
from
43287e7 to
f98c7e2
Compare
alfsb
approved these changes
Feb 11, 2026
Member
alfsb
left a comment
alfsb
left a comment
There was a problem hiding this comment.
I do not use these skeletons, but these changes appear to be simple enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<classsynopsisinfo role="comment">&Methods;</classsynopsisinfo>inskeletons/exceptionname.xmlclassname.xmlhas this header once before the constructor include;exceptionname.xmlhad it twice (lines 33 and 35)File changed
skeletons/exceptionname.xml— 1 line removed