Loading retry improvements#6974
Open
pavle-goloskokovic wants to merge 7 commits intophaserjs:masterfrom
Open
Conversation
…possible to override loader value per file, since there is no way to define properties on fileConfig directly
… but will retry loading
…thod calls, so it can forward it to FILE_LOAD_ERROR event emits, to give more details about the cause of error to listeners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves an existing feature:
maxRetriesvalue to5, which together with exponential backoff increases possible loading error recovery time to ~3 seconds compared to previous less then 100msFILE_LOAD_RETRYevent to Loader Plugin to enable listening to retry occurrencesFILE_LOAD_ERRORnow also emits Event that resulted form an error as an argument to provide more details to user regarding error causemaxRetriessetting fromFileConfigtoXHRSettingsObjectprovided to any Loader Plugin method call, to make it possible to override value per file, since there is no way to define properties onfileConfigdirectly