(winnie) Fix struct stat redefinition - reorder includes#3069
Merged
robe2 merged 1 commit intopgRouting:mainfrom Feb 18, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows MinGW compilation error in the main branch by reordering includes in src/cpp_common/report_messages.cpp. The issue occurs when C++ standard library headers (which include <sys/stat.h>) are included before PostgreSQL headers that redefine struct stat on Windows, causing redefinition errors. This fix mirrors the solution already applied to the develop branch in PR #3068.
Changes:
- Reordered includes to place PostgreSQL headers before C++ standard library headers
- Moved
report_messages.hppinclude from before theextern "C"block to after<sstream>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robe2
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3067 (for main branch)
This PR applies the same struct stat redefinition fix to the main branch, matching the fix already merged into develop via PR #3068.
Changes
Reordered includes in
src/cpp_common/report_messages.cppso that PostgreSQL headers are included before C++ headers, following the pattern used in previous fixes (#2648).@pgRouting/admins