Lang/rename to english - Full translation of comments and code.#98
Lang/rename to english - Full translation of comments and code.#980yech wants to merge 20 commits intopetitlapin:mainfrom
Conversation
|
Hi, thanks for the PR! Was it done with AI or are you fluent in French/English? I've started the checks to ensure if it is building / compliant with the formatting (it seems not for the second one). It will take time to review (I think some comments are not needed at all, so it would be better to directly remove them instead of translating them for example) but it's really important to have the source translated in English if we want more contributors :). |
|
Hello again, this was made by hand without AI. I am fluent in french, Ri-Li was a very popular game in primary school computers in Switzerland. Noticed the translation issues and thought it'd be great to get a good look at the entire project. I didn't see the Formatting checks beforehand, I don't mind making necessary changes for it. |
| #include "preference.h" | ||
|
|
||
| /*** Variable globales ***/ | ||
| /*** Global variables ***/ |
There was a problem hiding this comment.
this is the kind of comment I think is useless: we know they are global variables, constructors or destructors, no need to tell it, it's obvious for anyone reading the file
|
|
||
| /*** Initialise l'Audio ***/ | ||
| /**************************/ | ||
| /*** Initializes audio ***/ |
There was a problem hiding this comment.
this one also is useless for me, the method name should be self-explanatory. So either Init is good enough to know we are initializing the audio, or we should rename it InitializeAudio and in both cases, no need of the comment
|
|
||
| /*** Charge une music 0=menu 1,2,3,4 = game ***/ | ||
| /**********************************************/ | ||
| /*** Loads a music track, 0 = menu music 1,2,3,4=game music tracks ***/ |
There was a problem hiding this comment.
this one is a valid one, the behaviour cannot be explained just with the name, it makes sense to have this comment
Thanks, I've just glanced through the changes and the quality looks good :). It will be complicated for me to take a deep look before next week. Would it be fine with you that you fix the issues raised in clang-tidy and clang-format, then I use your branch to directly push the comments I think should be removed? In the end, I'll squash and merge the PR with only one commit with you as author? I think if I have to run on all the comments in the PR, then ask you to do the changes, it will take more time, it won't really be enjoyable for you to "just" remove comments, so it might be better to do it this way? In all cases, thank you a lot for taking the time to do it! edit: for the formatting, if you have clang-format in version 21 in your computer, it's only a matter of |
|
Your idea is fine to me, I'll do the format changes needed, it's not a problem. I'll also clean up other things if I notice anything missing. |
Full English Translation + Variable/Code Renaming
Related issues : #59 #60
This PR provides a somewhat complete translation of the French elements present in Li-Ri's source code. The code logic remains untouched. Original French comments have been replaced with English equivalents, and variables with explicitly French names have been renamed to English counterparts.
Due to its nature, this PR is quite large. If it can't be merged you at least have all comments translated.
Comments are direct English translations to preserve their original intent.
Feedback on variable/code naming choices is very welcome.