Added new menu OST by zabidenhtf · Pull Request #93 · petitlapin/Li-Ri

zabidenhtf · 2026-03-07T15:52:41Z

No description provided.

zabidenhtf · 2026-03-11T04:57:10Z

Hello, when my pr will be merged?

petitlapin · 2026-03-11T10:45:56Z

Hi, I won't have time to test it before 10 days unfortunately.
Multiple points:

Are you the creator of the music? If yes, do you confirm the license is GPLv3+?
If not, where did you find it and did you check the license is coherent with ours?
Would it make sense to have an option in the menu to choose between the old and new audio? This way the users can choose which one they prefer.

zabidenhtf · 2026-03-11T13:57:34Z

Yes, I'm author, if you want I'm can send on email source LMMS file project

zabidenhtf · 2026-03-11T14:05:37Z

And also I'm confirmed license

zabidenhtf · 2026-03-14T14:17:16Z

Also, im now making update with new ROYALTY FREE sounds, im will make PR later (Because in my opinion old 2000s sounds is BAD)

zabidenhtf · 2026-03-21T07:16:59Z

Hello, what about this PR?

petitlapin · 2026-03-21T08:30:25Z

I finally found the time to test!
The sound is nice, I have a few notes:

I think it would be better if we manage to create an "infinite" loop on the audio without the blank at the end (like the end of the audio should match with the beginning), do you think it is doable?
The file in wav format in 10MB which is quite big, is it possible to encode it in a smaller format usable by sdl_mixer without quality loss?
I would really like to have an option to use the previous sounds or the new ones. I'm fine with the new ones being the default ones too so by default, it will be your sounds :).

zabidenhtf · 2026-03-21T10:46:37Z

Ok, sure im can make loop
Ok, im can compress it to ogg or mp3
Ok, im make switch to select new or old

zabidenhtf · 2026-03-21T10:56:09Z

Im converted it into OGG, and now it not 10 MB

zabidenhtf · 2026-03-21T11:00:35Z

And also, what about adding source LMMS source file into project? Because in Ri-li was XM files (Fast tracker II source files).

petitlapin · 2026-03-21T11:03:32Z

And also, what about adding source LMMS source file into project? Because in Ri-li was XM files (Fast tracker II source files).

yes please, having the source file (and in the readme a quick "how to generate the audio" is good)

petitlapin · 2026-03-21T11:07:23Z

Im converted it into OGG, and now it not 10 MB

Thank you!

zabidenhtf · 2026-03-21T11:14:01Z

Added LMMS source

zabidenhtf · 2026-03-21T11:14:27Z

And also, im will add more my copyrights (like in readme, authors)

zabidenhtf · 2026-03-21T13:47:06Z

Also, in my opinion for Li-Ri doesn't need 2000s stuff

petitlapin · 2026-03-21T14:15:54Z

Also, in my opinion for Li-Ri doesn't need 2000s stuff

It's not because it does not fit your taste that other people don't enjoy these sounds and might even prefer them to the ones you have/will create. So the best compromise is to allow the users to choose which sounds they prefer.

And it's not because it has been created 20 years ago that it is "bad". It's a different generation, with different design/trends :).

zabidenhtf · 2026-03-21T14:48:58Z

And also, i dont know how make UI switch

zabidenhtf · 2026-03-21T14:49:19Z

Can you give for me idea (because in code you can switch and in ui no)

petitlapin · 2026-03-21T15:02:28Z

Can you give for me idea (because in code you can switch and in ui no)

In Menu::InitMain_Options we need to add a new button, and in the loop handling the menu, we need to store in preferences depending on the value. I would suggest to not add any image, just texts: "theme:" with values: "Zabiden"/"Maf"

I can take a look to add it myself if you want.

zabidenhtf · 2026-03-21T15:09:47Z

ALSO, IM FORGOT TO RETURN COPYRIGHT FOR MENU_LEGACY.mod

zabidenhtf · 2026-03-21T15:11:15Z

Returned copyright

zabidenhtf · 2026-03-21T15:12:09Z

Can you give for me idea (because in code you can switch and in ui no)

In Menu::InitMain_Options we need to add a new button, and in the loop handling the menu, we need to store in preferences depending on the value. I would suggest to not add any image, just texts: "theme:" with values: "Zabiden"/"Maf"

I can take a look to add it myself if you want.

Ok, im give for you this task make selector

zabidenhtf · 2026-03-22T13:28:13Z

Hello, what about your update?

petitlapin · 2026-03-22T16:51:39Z

Hello, what about your update?

I have an almost working patch. Is it ok with you if I directly push in your branch (I'll do a commit on top for now, then I would like to be able to rewrite the history directly, it will be easier to clean it)?

petitlapin · 2026-03-22T17:57:02Z

Sounds/menu.mmpz

I think the one pushed is the one with the blank at the end, and not the updated one (infinite loop). Can you please double check and update it if needed?

petitlapin · 2026-03-22T17:59:27Z

src/menu.cc

            Ec.PrintSprite(arrows, 4, 450, 300);
        }

+        switch (Pref.AudioTheme) {


One thing I'm not happy with this solution in the menu is that we don't know what this value is about...
We have 2 choices here: either we do what is done for the other selectors and add an image, or we add a text "Audio theme"

In my opinion we can just add text for first time (and also, don't make now release 3.1.7, because I'm want to finish some more important tasks (like close a bit issues))

I don't plan to do release 3.1.7 with just this, but I prefer to add the changelog when we do the changes, to ensure I don't forget something important when doing the release.

petitlapin · 2026-03-22T18:00:15Z

src/menu.cc

+            DrawString(430, 400, "MAF", Sprites[fmenu].Image[0]);
+            break;
+        case mZabiden:
+            DrawString(380, 400, "ZABIDEN", Sprites[fmenu].Image[0]);


Feel free to rename it as you prefer, I used the author names

petitlapin · 2026-03-22T18:10:40Z

NEWS.yaml

+Version: 3.1.7
+Date: 2026-xx-xx
+Description:
+  - New audio menu music created by zabidenhtf (Mykyta Polishyk)


is this line fine for you for credits in the NEWS?

Yes, sure 😄

zabidenhtf · 2026-03-23T08:01:28Z

Hello, look, im made new melody for Li-ri (You can write issues with this song, im will fix)

zabidenhtf · 2026-03-25T12:23:09Z

Also, im added another new melody (By me)

Added new menu OST

b5b540a

zabidenhtf mentioned this pull request Mar 7, 2026

Replace old Fast tracker OST on new #92

Open

OST have been converted into ogg, and looped

14e5ce4

Added LMMS source file

ba19902

Added my copyright into readme and authors

9c3015d

Added switch between old and new music

79a2b92

Returned copyright

ecb2fa9

add option in the menu

40a17d5

petitlapin force-pushed the music branch from 3041aa6 to 40a17d5 Compare March 22, 2026 17:55

petitlapin reviewed Mar 22, 2026

View reviewed changes

separate authors + add NEWS.yaml

f00abd4

petitlapin force-pushed the music branch from 1a61789 to f00abd4 Compare March 22, 2026 18:10

petitlapin reviewed Mar 22, 2026

View reviewed changes

Added new ingame melody and fixed menu melody

eb81c6d

zabidenhtf added 2 commits March 23, 2026 08:06

Removed intro from ingame1.ogg

06d4fc5

Added new melody (in techno style)

98366bc

Conversation

zabidenhtf commented Mar 7, 2026

Uh oh!

zabidenhtf commented Mar 11, 2026

Uh oh!

petitlapin commented Mar 11, 2026

Uh oh!

zabidenhtf commented Mar 11, 2026

Uh oh!

zabidenhtf commented Mar 11, 2026

Uh oh!

zabidenhtf commented Mar 14, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

petitlapin commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

petitlapin commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petitlapin commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

petitlapin commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

petitlapin commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 21, 2026

Uh oh!

zabidenhtf commented Mar 22, 2026

Uh oh!

petitlapin commented Mar 22, 2026

Uh oh!

petitlapin Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

petitlapin Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

zabidenhtf Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

petitlapin Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

petitlapin Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

petitlapin Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

zabidenhtf Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

zabidenhtf commented Mar 23, 2026

Uh oh!

zabidenhtf commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

petitlapin commented Mar 21, 2026 •

edited

Loading

petitlapin commented Mar 21, 2026 •

edited

Loading