Merged
Conversation
Contributor
Author
|
I also have a more aggressive refactoring which builds on top of this branch, and manages hook activation/deactivation according to the login state so that hooks will no longer even run when logged out. As part of this I moved all hooks to handlers similar to I understand that might be too ambitious for a bug fix though, so I didn't PR it, but let me know if I should: nebel/PrefPro@nebel:PrefPro:more-defensive-name-handling...nebel:PrefPro:refactor-hook-activation |
Closed
Owner
|
Thank you for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the last fix was not enough to due
ConfigHolder.GetOrDefaultalso depending on the current name. To prevent this I pull the name fromNameHandlerCacheinstead (which is safe on any thread) while allowing the name to default to""if unavailable. Then in the settings window there's a bunch of defensive code to make sure the player exists first and if so, load the real name in there.