fix: Remove vitest since it's not compatible with webpack #266
Conversation
|
@dlabaj it looks like this has 51 files changed, more than just the description would suggest - thinking it shouldn't be targeting the main branch? Also a small lint error about import order by alphabetical name. |
|
@evwilkin Fixed the branch it was going into, thanks for catching that. It should be going into the compass_theme branch. |
| "jsdom": "^25.0.1", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^29.7.0", | ||
| "jest-fixed-jsdom": "^0.0.9", |
There was a problem hiding this comment.
yes by jest in setup. It's used when running tests.
There was a problem hiding this comment.
If it were being used it would be specified as the testEnvironment in jest.config.cjs, right? If this is wrong, please explain.
Instead I see testEnvironment: 'jest-environment-jsdom',, so I'm still not sure how jest-fixed-jsdom is used, as its not imported or specified anywhere else I can see.
jpuzz0
left a comment
jpuzz0
left a comment
There was a problem hiding this comment.
Outside of the 1 lint issue and 1 minor comment, LGTM
3 participants
Vitest can only be used with Vite. Since this product is being built using webpack at the moment, we can not use vitest. We can create a new vite branch to allow users who want to use vite to checkout that branch instead.
Closes issue: #264