initial enlistment of core architecture skills

[krisnye]

Initial architectural skills added for

• ecs (adobe/data ecs)
• layout (ui terminal vs container components)
• lit (best practices with ecs)
• namespace (pattern for discoverable tree shakeable type utility functions)
• observe (adobe/data observe)
• react (best practices with ecs)
• service (authoring async data services)
• structure (best practices for overall project folder/file structures and interdependencies)

[ericelliott]

@cursoragent please /review - make sure skills are in ai/skills and commands have /aidd- prefix.

[cursor]

🔬 Code Review

🎯 Review Focus: Skills location and command prefix compliance

Critical Issues Found

1. Skills Location Duplication ❌

Current State:

• Skills exist in both .cursor/skills/ AND ai/skills/
• Both directories contain identical skill folders: ecs, layout, lit, namespace, observe, react, service, structure

Required State:

• Skills should ONLY be in ai/skills/
• .cursor/skills/ should not exist

Impact:

• Violates the project's stated architecture (per PR requirements)
• Creates maintenance burden (two locations to update)
• Confusing for contributors and agents

Action Required:

• Remove the entire .cursor/skills/ directory and its contents
• Verify all skill references point to ai/skills/ (already correct in current codebase)

---

2. Command Prefix Non-Compliance ❌

Current State:
Commands use / prefix throughout the codebase:

• /help, /log, /commit, /plan, /discover, /task, /execute, /review, /user-test, /run-test

Required State:
Commands should use /aidd- prefix:

• /aidd-help, /aidd-log, /aidd-commit, /aidd-plan, /aidd-discover, /aidd-task, /aidd-execute, /aidd-review, /aidd-user-test, /aidd-run-test

Locations Requiring Updates:

Primary definitions:

• ai/rules/please.mdc (lines 36-45) - Main command definitions
• ai/rules/task-creator.mdc (lines 168-171) - Task commands
• ai/rules/review.mdc (line 50) - Review command
• ai/rules/user-testing.mdc (lines 140-141) - Testing commands

Documentation:

• README.md (lines 70-76, 150-153, 170-172) - Quick start and workflow sections
• CONTRIBUTING.md (line 7, 37, 55) - Development workflow references
• docs/user-testing.md (lines 80, 114, 135, 237-238, 285-286) - Testing workflow
• docs/new-project-setup-nextjs-shadcn.md (lines 44, 65, 78, 80) - Setup guide
• docs/vision-document.md (line 213) - Vision document example
• docs/security.md (lines 3, 204, 214) - Security documentation
• .github/pull_request_template.md (line 4) - PR template

Archived tasks (likely safe to leave as historical record):

• Multiple files in tasks/archive/ contain old command references

Impact:

• Breaks naming convention consistency
• Prevents namespace collision with other AI systems
• Makes AIDD commands less discoverable and identifiable

Action Required:

• Update all 10 command names to use /aidd- prefix in all locations above
• Maintain consistency across documentation and code

---

Additional Observations

✅ Skills are correctly structured - Each skill has proper frontmatter and follows expected patterns

✅ ai/skills directory exists - No structural issues with the target location

✅ Commands are well-documented - Each has emoji, description, and constraints

---

Recommended Change Order

1. First: Remove .cursor/skills/ directory (simple, low-risk)
2. Second: Update command prefixes systematically:
   • Start with ai/rules/*.mdc files (source of truth)
   • Then update ai/commands/*.md files (command definitions)
   • Finally update README.md and docs/*.md (documentation)
   • Consider leaving archived task files unchanged (historical record)

---

Review Summary

Files to Modify: ~15-20 files
Lines to Change: ~40-50 command references
Breaking Changes: Yes - all users must update from /command to /aidd-command
Risk Level: Low - mostly find/replace operations
Test Impact: None - no code logic changes, only naming

The changes are straightforward but require careful systematic updates across documentation to maintain consistency.

  

[janhesters]

I'm working on a PR to migrate all existing rules to agent skills: #83

We want to prefix all skills with aidd- to avoid clashing. So could we rename the skills here, too? E.g. aidd-ecs?

Additionally, these skills here are written in plain markdown. Should we migrate them to SudoLang?

[janhesters]

Haha, you rewrote the code snippets in SudoLang, vs. the actual skill.

@ericelliott would be good to hear your thoughts whether this is enough, or the skills in general should be SudoLang. Other than that, LGTM now.