Adding conditional Log Detective variables to configuration templates#687
Open
jpodivin wants to merge 1 commit intopackit:mainfrom
Open
Adding conditional Log Detective variables to configuration templates#687jpodivin wants to merge 1 commit intopackit:mainfrom
jpodivin wants to merge 1 commit intopackit:mainfrom
Conversation
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
jpodivin
force-pushed
the
logdetective
branch
from
7d28372 to
d20dab9
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
jpodivin
force-pushed
the
logdetective
branch
from
d20dab9 to
ce3f8b7
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
jpodivin
force-pushed
the
logdetective
branch
from
ce3f8b7 to
0cc5678
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've used the same approach as utilized by other secrets. Both URL and token will be stored in bitwarden and rendered into template only if the URL is present. Log Detective interface server will always require authentication. Therefore, any configuration when URL is set, but the token is missing, is not viable.
Since removing the fields from configuration can be accomplished by just renaming, or removing, the variables in bitwarden, the fields were added to both prod and stage configuration templates.
RELEASE NOTES BEGIN
Log Detective URL and token are now conditional part of the service configuration.
RELEASE NOTES END