Conversation
# Conflicts: # package-lock.json # package.json
There was a problem hiding this comment.
Pull request overview
This PR constrains the Playwright peer dependency version to avoid a bug introduced in Playwright 1.58.0 that causes duplicate test title errors (referenced issue: microsoft/playwright#39172). The constraint >=1.36.0 <1.58.0 allows versions from 1.36.0 up to (but not including) 1.58.0.
Changes:
- Updated peer dependency constraint for
@playwright/testfrom^1.55.1to>=1.36.0 <1.58.0in both package.json and package-lock.json - Added documentation in README.md explaining the version constraint and the reason for it
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updated peerDependencies to constrain Playwright version to <1.58.0 |
| package-lock.json | Updated peerDependencies to match package.json constraint |
| README.md | Added NOTE explaining the Playwright version constraint and workaround guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| ``` | ||
|
|
||
| > [!NOTE] | ||
| > Playwright 1.58.0.0 introduced a [bug](https://github.com/microsoft/playwright/issues/39172) that causes duplicate test title errors. The latest release of this library version locks Playwright to <1.58.0 to avoid this issue, but if you are using a later version of Playwright in your project, you may need to adjust the version in your `package.json` to avoid conflicts. |
There was a problem hiding this comment.
The phrasing "The latest release of this library version locks" is awkward and unclear. Consider rephrasing to "This library version locks" or "This version of the library constrains" for better clarity.
| > Playwright 1.58.0.0 introduced a [bug](https://github.com/microsoft/playwright/issues/39172) that causes duplicate test title errors. The latest release of this library version locks Playwright to <1.58.0 to avoid this issue, but if you are using a later version of Playwright in your project, you may need to adjust the version in your `package.json` to avoid conflicts. | |
| > Playwright 1.58.0.0 introduced a [bug](https://github.com/microsoft/playwright/issues/39172) that causes duplicate test title errors. This version of the library locks Playwright to <1.58.0 to avoid this issue, but if you are using a later version of Playwright in your project, you may need to adjust the version in your `package.json` to avoid conflicts. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated note about Playwright version constraint for clarity.
lardo-de-arnaud
left a comment
lardo-de-arnaud
left a comment
There was a problem hiding this comment.
straight into the back of the net by the young lad Johnson.
Due to microsoft/playwright#39172 we just want to make sure we're not pulling in the latest version for now.