Skip to content

Add missing CRLF to regression test request bodies#3497

Merged
airween merged 1 commit intoowasp-modsecurity:v3/masterfrom
hnakamur:add_crlf_to_multipart_test_cases
Feb 17, 2026
Merged

Add missing CRLF to regression test request bodies#3497
airween merged 1 commit intoowasp-modsecurity:v3/masterfrom
hnakamur:add_crlf_to_multipart_test_cases

Conversation

@hnakamur
Copy link
Contributor

what

  • Add missing CRLF to request body lines in regression tests.
  • Also updated Content-Length by running the following command:
    (cd test && UPDATE_CONTENT_LENGTH=1 ./regression_tests format)
    

why

  • To make the request bodies to be correct multipart data.
  • I added CRLF to request lines in only failed tests in V3/do not add newline to test body lines #3486, but I also should have add CRLF to multipart request lines without newline characters.

references

Also updated Content-Length by running the following command:
```
(cd test && UPDATE_CONTENT_LENGTH=1 ./regression_tests format)
```
@sonarqubecloud
Copy link

Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airween airween merged commit b4f23d0 into owasp-modsecurity:v3/master Feb 17, 2026
50 checks passed
@airween
Copy link
Member

airween commented Feb 17, 2026

Thank you @hnakamur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments