Skip to content

Hardening: Avoid shell-based popen usage in InspectFile operator #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
praneet390 wants to merge 1 commit into
base: v3/master
Choose a base branch
from
+6 −0
Open

Hardening: Avoid shell-based popen usage in InspectFile operator #3489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/operators/inspect_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ bool InspectFile::evaluate(Transaction *transaction, const std::string &str) {
std::string res;
std::string openstr;

// SECURITY HARDENING NOTE:
// popen() executes via shell with concatenated arguments.
// Current inputs are engine-controlled, but replacing this
// with argv-based exec/spawn would remove shell parsing risk.


openstr.append(m_param);
openstr.append(" ");
openstr.append(str);
Expand Down
Loading