AO3-7283 Configurable number of shards for pseuds and tags index#5590
Open
not-varram wants to merge 1 commit intootwcode:masterfrom
Open
AO3-7283 Configurable number of shards for pseuds and tags index#5590not-varram wants to merge 1 commit intootwcode:masterfrom
not-varram wants to merge 1 commit intootwcode:masterfrom
Conversation
Bilka2
changed the title
Bilka2
requested changes
Mar 3, 2026
Comment on lines
+790
to
+791
| PSEUDS_SHARDS: 5 | ||
| TAGS_SHARDS: 5 |
Contributor
There was a problem hiding this comment.
these should be PSEUD_SHARDS and TAG_SHARDS please, to match the naming of the indexer classes
| PSEUDS_SHARDS: 5 | ||
| TAGS_SHARDS: 5 | ||
| WORKS_SHARDS: 5 | ||
| USER_SHARDS: 5 |
Contributor
There was a problem hiding this comment.
can you reorder this one to be alphabetical as well while you're here?
|
|
||
| describe PseudIndexer, pseud_search: true do | ||
| describe ".index_all" do | ||
| it "uses configured shard count when creating the index" do |
Contributor
There was a problem hiding this comment.
Could you work with expect(...).to receive here instead of the allow and have_received combination? to receive is much more common in our test suite so it'd be nice to stick to that established style. Same for the other test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Purpose
Adds
TAGS_SHARDSandPSEUDS_SHARDSconfig values and uses them when recreating tag and pseud search indexes.Testing Instructions
docker compose run --rm test bundle exec rspec spec/models/search/pseud_indexer_spec.rb spec/models/search/tag_indexer_spec.rb spec/lib/tasks/search_tasks.rake_spec.rbdocker compose run --rm web bundle exec rake search:index_pseudsdocker compose run --rm web bundle exec rake search:index_tagsExpected: all pass with no errors.
Or just run it and ensure it builds :)
Credit
not-varram (he/him)