AO3-7293 Add unactioned and unwrangleable status filters to tag search#5588
AO3-7293 Add unactioned and unwrangleable status filters to tag search#5588marcus8448 wants to merge 6 commits intootwcode:masterfrom
Conversation
It doesn't make sense to search for both separately (e.g. can't be canon + unwrangleable), and status=unwrangleable should cover it. It appears to be unused (and was not exposed to tag search).
| <li> | ||
| <%= f.radio_button :wrangling_status, "noncanonical_nonsynonymous_not_unwrangleable" %> | ||
| <%= f.label :wrangling_status, t(".status_option.noncanonical_nonsynonymous_and_not_unwrangleable"), value: "noncanonical_nonsynonymous_not_unwrangleable" %> | ||
| </li> | ||
| <li> | ||
| <%= f.radio_button :wrangling_status, "unwrangleable" %> | ||
| <%= f.label :wrangling_status, t(".status_option.unwrangleable"), value: "unwrangleable" %> | ||
| </li> |
There was a problem hiding this comment.
Should the order of these two be swapped?
There was a problem hiding this comment.
I purposely swapped the order from the issue because I think it makes more sense to have "Non-canonical and non-synonymous" immediately precede "Non-canonical and non-synonymous and not marked unwrangleable" since they filter similar things. I also think it looks a bit nicer (since the names are so long+similar).
add associated "wrangleable" status, add tests to match
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
This code looks good, so I'm approving! Especially thank you for the extra tests <3
However, I'm keeping the coder actioned label because Tag Wrangling wants to rename the really really long search option, and that way that will stay on our radar. Feel free to poke me if wrangling hasn't updated the Jira issue for that within a few weeks
2 participants
Issue
https://otwarchive.atlassian.net/browse/AO3-7293
Purpose
Adds two more wrangling status options to tag search: "Unwrangleable" and "Non-canonical and non-synonymous and not marked unwrangleable" (which are tags that have not been actioned in some way).
Credit
marcus8448 (he/him)