Skip to content

cao: remove unused built image from variant configs#77392

Open
petr-muller wants to merge 1 commit intoopenshift:mainfrom
petr-muller:cao-periodic-do-not-build-images
Open

cao: remove unused built image from variant configs#77392
petr-muller wants to merge 1 commit intoopenshift:mainfrom
petr-muller:cao-periodic-do-not-build-images

Conversation

@petr-muller
Copy link
Copy Markdown
Member

Replaces #72740

The periodics variant configs do not need to contain images stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to releases.latest unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.

The `periodics` variant configs do not need to contain `images` stanza (unless something in the jobs themselves needs the built image). The periodics are configured to install/update to `releases.latest` unmodified, but the jobs will still build the image from whatever the corresponding branch HEAD at the trigger time. This takes time, a bit of compute and also causes a redundant -images job to exist. None of this is necessary.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign liouk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from ibihim and liouk April 3, 2026 23:01
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@petr-muller: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-cluster-authentication-operator-release-4.22-periodics-e2e-aws-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.23-periodics-e2e-azure-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-gcp-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-vsphere-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.23-periodics-e2e-aws-sno-external-oidc-configure N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-metal-ovn-ipv6-external-oidc-configure N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-metal-ovn-dualstack-external-oidc-revertoauth N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.22-periodics-e2e-vsphere-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-gcp-external-oidc-rollback N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.22-periodics-e2e-azure-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-gcp-external-oidc-uid-extra-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-azure-external-oidc-uid-extra-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-azure-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.23-periodics-e2e-metal-ovn-dualstack-external-oidc-configure N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-vsphere-external-oidc-configure N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-dualstack-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-rollback N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.22-periodics-e2e-gcp-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.23-periodics-e2e-aws-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-uid-extra N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.22-periodics-e2e-metal-ovn-dualstack-external-oidc-revertoauth N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-4.22-periodics-e2e-metal-ovn-ipv6-external-oidc-revertoauth N/A periodic Ci-operator config changed
periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-gcp-external-oidc-configure N/A periodic Ci-operator config changed

A total of 144 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2026

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-aws-external-oidc-uid-extra 51ebbb9 link unknown /pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-aws-external-oidc-uid-extra

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller
Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants