SDCICD-1804 Fix S3 upload failure on GCP clusters#3196
SDCICD-1804 Fix S3 upload failure on GCP clusters#3196openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
|
There are test jobs defined for this repository which are not configured to run automatically. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YiqinZhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
ref: SDCICD-1804 |
ede3ad6 to
02588bb
Compare
|
/pipeline required |
|
Scheduling required tests: |
16bcdfd to
311b0ed
Compare
|
/test hypershift-pr-check |
311b0ed to
f8f3d47
Compare
f8f3d47 to
dd16ec8
Compare
dd16ec8 to
53d4e54
Compare
|
/lgtm |
|
/override ci/prow/hypershift-pr-check |
|
@YiqinZhang: Overrode contexts on behalf of YiqinZhang: ci/prow/hypershift-pr-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@YiqinZhang: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
S3 artifact uploads fail on GCP clusters because the cluster's cloud provider region (us-east1, GCP format) is used as the AWS S3 region, producing an invalid endpoint s3.us-east1.amazonaws.com.
Add a
logsBucketRegionconstant (us-east-1) ins3.go, co-located with the existinglogsBucketconstant.Use
sess.Copy()to create a region-overridden S3 session that keeps the shared AWS credentials but always targets the correct bucket region, independent of the cluster's cloud provider.Co-authored-by: Cursor cursor@cursor.com