Skip to content

[release-4.20] OCPBUGS-76790: Fix make test#157

Open
openshift-cherrypick-robot wants to merge 2 commits intoopenshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-154-to-release-4.20
Open

[release-4.20] OCPBUGS-76790: Fix make test#157
openshift-cherrypick-robot wants to merge 2 commits intoopenshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-154-to-release-4.20

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 13, 2026

This is an automated cherry-pick of #154

/assign openshift-ci-robot

@mandre
Fix kubebuilder-tools download URL
81884a2 
The old download URL at storage.googleapis.com/kubebuilder-tools/ returns
HTTP 403 (AccessDenied), breaking 'make test'. Update to the new location
at github.com/kubernetes-sigs/controller-tools/releases/ and adjust the
extraction logic for the new archive structure (controller-tools/envtest/
instead of kubebuilder/bin/).

See kubernetes-sigs/kubebuilder#4082
@mandre
Skip kubebuilder-tools download when envtest tests are disabled
15d41ac 
The only test requiring kubebuilder-tools (envtest.Environment in
pkg/machineset/controller_suite_test.go) is currently skipped. Set
SKIP_FETCH_TOOLS=1 to avoid an unnecessary download during 'make test'.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2026
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2026

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-76788 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.20] OCPBUGS-76790: Fix make test

Details

In response to this:

This is an automated cherry-pick of #154

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-76788: Fix make test [release-4.20] OCPBUGS-76790: Fix make test Feb 13, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 13, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-76790, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-76789 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #154

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mandre
mandre reviewed Feb 13, 2026
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed
/verified by ci/prow/unit

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 13, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026
@mandre
Copy link
Member

mandre commented Feb 13, 2026

The changes are limited to unit tests. They do not impact e2e tests at all, it's fine to ignore the (currently fragile) e2e-openstack job.
/override ci/prow/e2e-openstack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@mandre: Overrode contexts on behalf of mandre: ci/prow/e2e-openstack

Details

In response to this:

The changes are limited to unit tests. They do not impact e2e tests at all, it's fine to ignore the (currently fragile) e2e-openstack job.
/override ci/prow/e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 15d41ac link true /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@mandre mandre

@itzikb-redhat itzikb-redhat

@openshift-ci-robot openshift-ci-robot

@imatza-rh imatza-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @mandre @itzikb-redhat @imatza-rh