OCPNODE-3880: Add empty CRIOCredentialProviderConfig resource

[QiWang19]

Add an empty singleton CRIOCredentialProviderConfig CR named cluster. As discussed, keep the behavior consistent with the current singleton CRDs.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a new OpenShift CRI-O credential provider configuration manifest file. The manifest defines a CRIOCredentialProviderConfig custom resource with apiVersion config.openshift.io/v1alpha1 and kind CRIOCredentialProviderConfig, named cluster. The resource includes four annotations for release management and feature gate control: one each for IBM Cloud managed and self-managed high availability inclusion, a create-only directive, and a feature gate annotation. The specification section remains empty. This is a static resource definition with no accompanying logic or controller changes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, so this check cannot assess the quality or relevance of a description.	Add a pull request description explaining the purpose and context of adding this empty resource configuration.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'OCPNODE-3880: Add empty CRIOCredentialProviderConfig resource' accurately and concisely describes the main change: adding a new empty CRIOCredentialProviderConfig resource manifest.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[QiWang19]

/test all

[qodo-code-review]

Unsupported PR languages

[qodo-code-review]

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Add empty CRIOCredentialProviderConfig resource definition

✨ Enhancement

Walkthroughs

Description

• Add empty CRIOCredentialProviderConfig resource definition
• Configure resource with cluster metadata and annotations
• Enable feature gate for credential provider configuration

Diagram

flowchart LR
  A["New Resource File"] -- "defines" --> B["CRIOCredentialProviderConfig"]
  B -- "with metadata" --> C["cluster name"]
  B -- "with annotations" --> D["Feature gates & release config"]
  B -- "with spec" --> E["Empty spec"]

Loading

File Changes

1. payload-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml ⚙️ Configuration changes +10/-0

Create CRIOCredentialProviderConfig resource manifest

• Create new CRIOCredentialProviderConfig resource manifest
• Set resource name to 'cluster' with config.openshift.io/v1alpha1 API version
• Add annotations for IBM Cloud managed, self-managed HA, and feature gate enablement
• Define empty spec for credential provider configuration

payload-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml

---

[qodo-code-review]

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. Novel feature-gate annotation on CR 🐞 Bug ✓ Correctness

Description

The release.openshift.io/feature-gate annotation is used here on a CR for the first time in this
codebase — every prior usage is exclusively on kind: CustomResourceDefinition objects. If CVO does
not honor this annotation for non-CRD resources, the CR will be applied on all clusters matching the
cluster-profile annotations (ibm-cloud-managed and self-managed-high-availability), including
Default feature-set clusters where the criocredentialproviderconfigs.config.openshift.io CRD does
not exist, causing a CVO error that could degrade the ClusterVersion operator.

Code

payload-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml[9]

+    release.openshift.io/feature-gate: "CRIOCredentialProviderConfig"

Evidence

Every occurrence of release.openshift.io/feature-gate in the repo is on a CRD manifest, never on a
CR. The CRIOCredentialProviderConfig CRD exists only for DevPreviewNoUpgrade, TechPreviewNoUpgrade,
and CustomNoUpgrade — no Default variant exists. The feature is explicitly in the disabled list
for Default clusters. No other file in payload-command/empty-resources/ uses this annotation.

payload-manifests/crds/0000_30_cluster-api_01_clusterapis-TechPreviewNoUpgrade.crd.yaml[9-10]
payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml[57-59]
payload-manifests/crds/0000_10_config-operator_01_criocredentialproviderconfigs-DevPreviewNoUpgrade.crd.yaml[1-10]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The `release.openshift.io/feature-gate` annotation has only ever been applied to `kind: CustomResourceDefinition` objects in this codebase. Applying it to a CR (`kind: CRIOCredentialProviderConfig`) is novel and unverified. If CVO does not honor this annotation for non-CRD resources, the CR will be applied on Default clusters where the CRD does not exist, causing a CVO error.

## Issue Context
- The CRIOCredentialProviderConfig CRD exists only for DevPreviewNoUpgrade, TechPreviewNoUpgrade, and CustomNoUpgrade feature sets.
- `CRIOCredentialProviderConfig` is in the `disabled` list for Default clusters (`payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml`).
- All other CRDs using `release.openshift.io/feature-gate` also carry `release.openshift.io/feature-set`.
- No other file in `payload-command/empty-resources/` uses `release.openshift.io/feature-gate`.

## Fix Focus Areas
- payload-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml[9-9]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[qodo-code-review]

1. Novel feature-gate annotation on cr 🐞 Bug ✓ Correctness

The release.openshift.io/feature-gate annotation is used here on a CR for the first time in this
codebase — every prior usage is exclusively on kind: CustomResourceDefinition objects. If CVO does
not honor this annotation for non-CRD resources, the CR will be applied on all clusters matching the
cluster-profile annotations (ibm-cloud-managed and self-managed-high-availability), including
Default feature-set clusters where the criocredentialproviderconfigs.config.openshift.io CRD does
not exist, causing a CVO error that could degrade the ClusterVersion operator.

Agent Prompt

## Issue description
The `release.openshift.io/feature-gate` annotation has only ever been applied to `kind: CustomResourceDefinition` objects in this codebase. Applying it to a CR (`kind: CRIOCredentialProviderConfig`) is novel and unverified. If CVO does not honor this annotation for non-CRD resources, the CR will be applied on Default clusters where the CRD does not exist, causing a CVO error.

## Issue Context
- The CRIOCredentialProviderConfig CRD exists only for DevPreviewNoUpgrade, TechPreviewNoUpgrade, and CustomNoUpgrade feature sets.
- `CRIOCredentialProviderConfig` is in the `disabled` list for Default clusters (`payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml`).
- All other CRDs using `release.openshift.io/feature-gate` also carry `release.openshift.io/feature-set`.
- No other file in `payload-command/empty-resources/` uses `release.openshift.io/feature-gate`.

## Fix Focus Areas
- payload-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml[9-9]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

[qodo-code-review]

Unsupported PR languages

[QiWang19]

/verified by Cluster-bot

[openshift-ci-robot]

@QiWang19: This PR has been marked as verified by Cluster-bot.

Details

In response to this:

/verified by Cluster-bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[QiWang19]

/test verify

[qodo-code-review]

Unsupported PR languages

[openshift-ci-robot]

@QiWang19: This pull request references OCPNODE-3880 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@QiWang19: This pull request references OCPNODE-3880 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add an empty singleton CRIOCredentialProviderConfig CR named cluster. As discussed, keep the behavior consistent with the current singleton CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@QiWang19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance	70ab6a8	link	true	/test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.