[BUG] Correct path to cache for cleanup of task download failure#1620
Open
[BUG] Correct path to cache for cleanup of task download failure#1620
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
- Coverage 52.36% 52.35% -0.02%
==========================================
Files 36 36
Lines 4333 4332 -1
==========================================
- Hits 2269 2268 -1
Misses 2064 2064 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
reviewed
Jan 23, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Have you checked that the test is running on remote?
Collaborator
Author
At the time of this PR it was up-to-date and CI passed. I'll update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that I believe was introduced in #1584: the function called already generates the directory that is task specific, so there is no need to check for a subdirectory. I believe that this patch achieves the intended behavior change of #1584. The corresponding unit test now passes (
tests/test_tasks/test_task_functions.py::test_removal_upon_download_failure), where it would previously fail since the subdirectory was never made.