chore(api): simplify ConvertMetadataToLabels using maps.Clone and lo.…

[borbelyr-kong]

Summary by CodeRabbit

• Refactor
  • Internal metadata label handling across API handlers was improved to ensure null-safe label returns and avoid accidental mutations, increasing reliability without changing public APIs.
• Improvement
  • Query parameter parsing was tightened to more reliably recognize date-time values, reducing parsing/validation issues for date-time query inputs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e2d67d and 57834b6.

⛔ Files ignored due to path filters (3)

• api/client/go/client.gen.go is excluded by !api/client/**
• api/client/javascript/src/client/schemas.ts is excluded by !api/client/**
• api/client/javascript/src/zod/index.ts is excluded by !api/client/**

📒 Files selected for processing (1)

• api/api.gen.go

---

📝 Walkthrough

Walkthrough

Refactored ConvertMetadataToLabels across multiple handlers to return non-nil *api.Labels by using maps.Clone + pointer wrapping; added stdlib maps and github.com/samber/lo imports. Also updated an OpenAPI-generated binding to use BindQueryParameterWithOptions for a date-time query parameter.

Changes

Cohort / File(s)	Summary
Metadata-to-Labels Conversion Refactor api/v3/handlers/apps/convert.go, api/v3/handlers/billingprofiles/convert.go, api/v3/handlers/customers/convert.go, api/v3/handlers/meters/convert.go, api/v3/handlers/subscriptions/convert.go, api/v3/handlers/taxcodes/convert.go	ConvertMetadataToLabels now early-returns &api.Labels{} for nil/empty input; for non-empty input it returns a pointer to a cloned map via maps.Clone cast to api.Labels and wrapped with lo.ToPtr. Added imports for maps and github.com/samber/lo. Replaced manual map population with clone-and-wrap.
OpenAPI binding change api/api.gen.go	Replaced runtime.BindQueryParameter(...) with runtime.BindQueryParameterWithOptions(..., runtime.BindQueryParameterOptions{Type:"string", Format:"date-time"}) for the at query param, adding explicit type/format options to parsing.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(api): add app endpoints to v3 api #3782 — modifies ConvertMetadataToLabels in api/v3/handlers/apps/convert.go, similar map-conversion changes.
• fix: properly convert internal Metadata to v3 api Labels type #3812 — broader ConvertMetadataToLabels refactor across handler files, aligns with these edits.

Suggested labels

release-note/ignore

Suggested reviewers

• gergely-kurucz-konghq
• tothandras

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring ConvertMetadataToLabels functions across multiple files to use maps.Clone and lo.ToPtr for cleaner implementation.
Docstring Coverage	✅ Passed	Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/simplify-metadata-to-labels

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gergely-kurucz-konghq]

Not necessarily in scope for this PR, but just wondering if we can somehow extract the refactored conversion function to a common place, after seeing it being repeated in multiple places. The Metadata -> Labels conversion seems to be a common concern. Something to think about. It might not worth it, or might not be simple with goverter.