#827 fix boolpredicate validation#828
Open
walker-sean wants to merge 2 commits intoopenapistack:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes issue #827 where supplying a predicate function for OpenAPIBackend’s validate option was being coerced to true, preventing conditional validation from working.
Changes:
- Rename
BoolPredicatetoContextPredicateand update thevalidateoption/member types accordingly. - Fix
OpenAPIBackendconstructor to preserve thevalidateoption value (boolean or predicate) instead of coercing it. - Add tests covering predicate-based validation behavior (skip vs run validation).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/backend.ts | Updates predicate type name and fixes validate assignment to avoid boolean coercion. |
| src/backend.test.ts | Adds regression tests ensuring validate predicates are invoked and affect validation flow. |
Comments suppressed due to low confidence (1)
src/backend.ts:75
- Renaming the exported
BoolPredicatetype toContextPredicateis a breaking public API change for TypeScript consumers (they may importBoolPredicatetoday), but the package version is still on the v5 minor line. Consider keeping a backward-compatible alias export (e.g.export type BoolPredicate = ContextPredicatewith a@deprecatedtag) so existing imports keep compiling while still steering users to the new name.
export type HandlerMap = { [operationId: string]: Handler | undefined };
export type ContextPredicate = (context: Context, ...args: any[]) => boolean;
/**
* The different possibilities for set matching.
*
* @enum {string}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #827
OpenAPIBackendconstructor fixed to properly assign thevalidateoption as a member.BoolPredicateto the more precise, less redundantContextPredicatevalidatevalue