fix: change prompt_cache_retention literal from in-memory to in_memory#2898
Open
thakoreh wants to merge 1 commit intoopenai:mainfrom
Open
fix: change prompt_cache_retention literal from in-memory to in_memory#2898thakoreh wants to merge 1 commit intoopenai:mainfrom
thakoreh wants to merge 1 commit intoopenai:mainfrom
Conversation
…mory' The API expects 'in_memory' (underscore) but the type annotations declared 'in-memory' (hyphen), causing 400 errors when using the typed value. Fixes openai#2883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2883
The SDK type annotations declared prompt_cache_retention with Literal[in-memory, 24h] (hyphen), but the API expects in_memory (underscore). Using the typed value as-is causes a 400 Bad Request.
Changed all occurrences in 9 files: