Closed
Conversation
Contributor
Author
|
Going to merge this in with #15276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test suite has been struggling on the darwin bazel test runners.
This fixes the CI flake in
suite::unified_exec::unified_exec_intercepts_apply_patch_exec_commandby relaxing the test’syield_time_msfrom 250ms to 5s. The test exercises the interceptedapply_patchpath, which spawns a helper process and can take longer than a very small unified-exec yield deadline on slower CI machines. No production timeout behavior changed.