Skip to content

Add parent-scoped guardian approval review events#15265

Open
charley-oai wants to merge 5 commits intomainfrom
cc/guardian-approval-review-lifecycle
Open

Add parent-scoped guardian approval review events#15265
charley-oai wants to merge 5 commits intomainfrom
cc/guardian-approval-review-lifecycle

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Mar 20, 2026

Summary

  • add experimental parent-scoped guardianApprovalReview notifications for command execution, file change, and MCP tool call items
  • keep emitting the legacy item/autoApprovalReview/* notifications as deprecated compatibility aliases
  • update the app-server README and regenerate protocol schema fixtures

@charley-oai charley-oai marked this pull request as ready for review March 21, 2026 00:42
@charley-oai
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai and others added 3 commits March 20, 2026 17:46
Emit experimental item-scoped guardian approval review notifications for command execution, file change, and MCP tool call items while keeping the legacy autoApprovalReview notifications as deprecated aliases. Update the app-server docs and generated protocol schema fixtures.

Co-authored-by: Codex <noreply@openai.com>
Remove the 'This shape is expected to change soon.' wording from the long-lived guardian approval review payload docs while keeping the API marked unstable. Regenerate the app-server protocol schema fixtures to match.

Co-authored-by: Codex <noreply@openai.com>
Strip 'This shape is expected to change soon.' from the guardian approval review protocol docs and regenerated schema fixtures, while keeping the affected APIs marked unstable or deprecated as appropriate.

Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the cc/guardian-approval-review-lifecycle branch from 97b6444 to adcbd45 Compare March 21, 2026 00:46
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97b644414b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Collaborator Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1106793bf7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Collaborator Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6762703fd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant