fix failed phase switches, manual lock init#3235
Merged
LKuemmel merged 2 commits intoopenWB:masterfrom Mar 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses chargepoint state handling by ensuring newly created chargepoints have manual_lock initialized and by tracking unsuccessful phase switch outcomes so the control logic can react appropriately.
Changes:
- Publish an initial
manual_lock = Falseretained value when creating a new chargepoint. - Add failure counting in
check_phase_switch_completed()when the requested phases are not reached after the phase-switch waiting period.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/helpermodules/command.py | Initializes the retained /set/manual_lock topic for newly added chargepoints. |
| packages/control/chargepoint/chargepoint.py | Increments failed_phase_switches when a phase switch does not result in the requested phases after waiting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.