WEB-718 Show required error message for days till field in delinquency range form

[JaySoni1]

Changed Made :-

• Made 'Days Till' field optional in Delinquency Range creation form to allow null values for the last range in delinquency buckets

WEB-718

Before :-

After :-

Summary by CodeRabbit

• Bug Fixes
  • The "maximum age" field in delinquency range creation is now optional; users can leave it blank while format and upper-limit checks remain enforced, reducing unnecessary required-field validation.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 427fea96-391c-40aa-a0a8-0769311f1114

📥 Commits

Reviewing files that changed from the base of the PR and between 54a3c77 and 41909f7.

📒 Files selected for processing (2)

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html
• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.ts

💤 Files with no reviewable changes (1)

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html

---

Walkthrough

Removed the required constraint for the maximumAgeDays field: the template input no longer has the required attribute and the component form control no longer includes Validators.required, making maximumAgeDays optional while retaining pattern/max constraints.

Changes

Cohort / File(s)	Summary
Delinquency range create form src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html, src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.ts	Removed client-side required enforcement for maximumAgeDays: deleted the required attribute in the template and removed Validators.required from the form control. Pattern and max validators remain unchanged. No other fields or submission flow modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• WEB-683 Fix validation messages in workflow jobs and create delinquency range shows default value 0 #3113: Modifies minimumAgeDays handling in the same create-range component (related validation changes).
• WEB-630 Days till field allows negative values in create delinquency range form #3051: Alters maximumAgeDays validation in the same component (conflicting/overlapping validation changes).

Suggested reviewers

• alberto-art3ch
• gkbishnoi07

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title claims to 'Show required error message' but the actual changes remove the required validator and make the field optional, which is the opposite of what the title describes.	Update the title to accurately reflect the changes, such as 'WEB-718 Make Days Till field optional in delinquency range form' or similar phrasing that matches the actual implementation.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[alberto-art3ch]

Please see my comments

[gkbishnoi07]

@JaySoni1 please check alberto comment

[JaySoni1]

@gkbishnoi07 @alberto-art3ch before I have made changes earlier the Days Till field was marked with a star, which indicated that it was mandatory and the form could not be submitted without filling it. Based on that, I added the validation message. However, since you mentioned that this field can be left empty so now have to remove the star mark and make the field optional ?