support prefix for prometheus exporter #4895
Open
+37
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Feb 10, 2026
| """Prometheus metric exporter for OpenTelemetry.""" | ||
|
|
||
| def __init__(self, disable_target_info: bool = False) -> None: | ||
| def __init__(self, prefix: str = "", disable_target_info: bool = False) -> None: |
Member
There was a problem hiding this comment.
i think this is a breaking change. yup, griffe detected it as a breaking change, but since this was supposed to work, can we treat it as a fix? @open-telemetry/python-maintainers
Overall, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PrometheusMetricReaderoriginally supported providing a prefix that would be added to all metric names. This feature is still present in the documentation but the behaviour was at some point lost.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: