-
Notifications
You must be signed in to change notification settings - Fork 801
TracerProvider(ABC) doc string correction #4894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TracerProvider(ABC) doc string correction #4894
Conversation
|
|
|
Isn't every instrumentation using |
Yes. I've purposefully done a minimal change, but as mentioned here, a less prescriptive docstring could be warranted:
That said, the current docstring is incorrect: @xrmx Would it make sense to still include a warning about using |
|
@xrmx Can the changelog be skipped for this? |
|
@42Questions I've opened open-telemetry/opentelemetry-python-contrib#4173 to pass an explicit value instead of |
Description
Correction to
class TracerProvider(ABC)docstring, extensively discussed but never implemented open-telemetry/opentelemetry.io#2517 .Correction to
class TracerProvider(ABC).get_meterdocstring as well with the same mistake.