Conversation
|
This still requires updating Edit: I actually found that the versions had diverged already. See Directory.Build.props (0.5.3) and src/Lua.Unity/Assets/package.json (0.5.1). Added the version check. |
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to run the test suite and (on semver tag pushes) publish the NuGet package, while marking a couple of inherited Lua test files as expected failures so CI can skip them.
Changes:
- Introduces
.github/workflows/nuget.ymlto restore, test (excludingExpectedFailure), pack, and publish onv*.*.*tags (or manual dispatch). - Marks
tests-lua/files.luaandtests-lua/errors.luatest cases asExpectedFailureso they can be filtered out in CI. - Ignores build output under
artifacts/in.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Lua.Tests/LuaTests.cs | Categorizes two Lua test cases as ExpectedFailure for CI filtering. |
| .gitignore | Adds artifacts/ to ignored paths. |
| .github/workflows/nuget.yml | New workflow for version validation, tests, packing, artifact upload, and NuGet publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Simple GitHub Action workflow to run tests and publish to NuGet. @nuskey8 This will require an API key stored as a secret. Runs on pushing a semver tag e.g.
v0.5.4or via explicit workflow dispatch.This PR also throws the
ExpectedFailureonto several of the test files inherited from Lua proper so we can skip them during CI. Note that additional test cases would requireExpectedFailureunless #279 is merged.